Expose current crawler in the scrapy shell. #557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
|
I think docs for Scrapy shell should be updated with this change - there is a listing of all objects available. See http://doc.scrapy.org/en/latest/topics/shell.html#available-scrapy-objects and example shell output later. |
…ell output. Also updated the shell example with a reproducible code example.
|
Updated shell output in the docs. Actually I went through the shell session examples and fixed the output with the latest output. Maybe a bit beyond the scope of this PR but also I improved the shell inspect example with a reproducible example code. |
pablohoffman
added a commit
that referenced
this pull request
Jan 28, 2014
Expose current crawler in the scrapy shell.
|
Thanks @darkrho for the proactive fixes, that doc does tend to get outdated easily! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the way to access the crawler in the shell is by import the object from the module
scrapy.project. But, that module is currently deprecated as stated in the same module.This pull request expose the current
crawlerobject in the shell making it easily accessible which is very useful to interact with middlewares, extensions and other classes that requires thecrawlerobject.